fix(helm): Fix rendering of dnsConfig for backend, read, write, single-binary and table-manager
What this PR does / why we need it:
Fixes below templating error when specifying dnsConfig in SimpleScalable deployment mode.
Error: loki/charts/loki/templates/write/statefulset-write.yaml:151:16
executing "loki/charts/loki/templates/write/statefulset-write.yaml" at <.>:
wrong type for value; expected string; got map[string]interface {}
The dnsConfig property is an object so we need to use toYaml. This aligns with how it's correctly handled and working in other components.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Supersedes stale PR #15537
Checklist
- [X] Reviewed the
CONTRIBUTING.mdguide (required) - [X] Documentation added
- [ ] Tests updated
- [X] Title matches the required conventional commits format, see here
- Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
- Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such,
- [X] Changes that require user attention or interaction to upgrade are documented in
docs/sources/setup/upgrade/_index.md - [ ] If the change is deprecating or removing a configuration option, update the
deprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR
For your review @QuentinBisson & team 🙏
I think it makes sense thank you :)
LGTM
I think it makes sense thank you :)
LGTM
Sure thing! What's pending to get this approved?
It needs a review from @Jayclifford345 or @nicolevanderhoeven
Hey @Jayclifford345 or @nicolevanderhoeven, can you take a look?
@JStickler can you review?
@illrill , I'm the technical writer on the team, not a developer.