loki icon indicating copy to clipboard operation
loki copied to clipboard

fix(helm): Fix rendering of dnsConfig for backend, read, write, single-binary and table-manager

Open illrill opened this issue 4 weeks ago • 6 comments

What this PR does / why we need it:

Fixes below templating error when specifying dnsConfig in SimpleScalable deployment mode.

Error: loki/charts/loki/templates/write/statefulset-write.yaml:151:16
  executing "loki/charts/loki/templates/write/statefulset-write.yaml" at <.>:
    wrong type for value; expected string; got map[string]interface {}

The dnsConfig property is an object so we need to use toYaml. This aligns with how it's correctly handled and working in other components.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Supersedes stale PR #15537

Checklist

  • [X] Reviewed the CONTRIBUTING.md guide (required)
  • [X] Documentation added
  • [ ] Tests updated
  • [X] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [X] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

illrill avatar Nov 25 '25 15:11 illrill

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 26 '25 08:11 CLAassistant

For your review @QuentinBisson & team 🙏

illrill avatar Nov 27 '25 16:11 illrill

I think it makes sense thank you :)

LGTM

QuentinBisson avatar Dec 01 '25 13:12 QuentinBisson

I think it makes sense thank you :)

LGTM

Sure thing! What's pending to get this approved?

illrill avatar Dec 02 '25 09:12 illrill

It needs a review from @Jayclifford345 or @nicolevanderhoeven

QuentinBisson avatar Dec 02 '25 09:12 QuentinBisson

Hey @Jayclifford345 or @nicolevanderhoeven, can you take a look?

illrill avatar Dec 08 '25 10:12 illrill

@JStickler can you review?

illrill avatar Dec 19 '25 10:12 illrill

@illrill , I'm the technical writer on the team, not a developer.

JStickler avatar Dec 19 '25 20:12 JStickler