Stephen Belanger

Results 391 comments of Stephen Belanger

> Monkey-patching is deprecated and after sufficient notice, removed. We should also make sure to verify with users that all the needs are covered before deprecating. For example, I know...

We can make use of the surveys and Twitter account to ask the community. I've done that before with gathering use cases that need covering to remove (or make internal-only)...

My preference is 3. I don't feel we're getting much from loaders being off-thread, _certainly_ not enough to justify the significant complexity. Also, we don't necessarily need a _thread_ to...

Is this an M1/M2 machine or Intel? Your reproduction case seems to not trigger this on my M1 MBP. I'm on macOS 13 so could be a difference between OS...

Thanks for the additional information! The profiler issue is _probably_ already fixed by DataDog/pprof-nodejs#71. As for the runtime metrics issue, I'll try to spin up a similar environment to see...

Seems to be crashing because of this: https://github.com/nodejs/node/commit/22cbbcf9d9374d4b663bf1409f292212fa57623a The native metrics code is currently doing an async shut down with `uv_close(...)` but that's invalid within `AddEnvironmentCleanupHook`. While it _technically_ will...

None yet. There's a logic conflict between Node.js 14 and earlier against later Node.js versions that basically means there _is_ no safe way to do cleanup on older Node.js versions...

What are your Node.js and dd-trace versions? It should be fixed on Node.js 16+, though it's only in the v4 line of dd-trace. It's not possible to fix in v14...

Can you update to the latest 4.x release and see if that fixes it for you? It should be cleaning up properly in 4.x.