Stephen Belanger

Results 391 comments of Stephen Belanger

I would have separate APIs for explicit hook passing and implicit sharing. Explicit: ```js new Workers('user.js', { hooks: [] }) ``` Implicit: ```js Worker.setDefaultHooks([]) ``` I might even go as...

Most APMs don't really do much of anything about threads currently, or just fallback on `-r` loading a separate instance of their library into every thread, so I think we're...

@tlhunter Can you do something with this while you're on ER?

Ah, so triggering off github releases is how we get the official release builds? Is it _desirable_ for this to be running on all pushes everywhere? That seems like a...

Seems to have some very strange git-related failures. https://ci.nodejs.org/job/node-test-binary-armv7l/RUN_SUBSET=js,nodes=ubuntu2204-armv7l/13225/console 🤔

I'm a fan of [KDL](https://kdl.dev/). I feel like the need for a config file format parser if we go with non-json (which we should because comments) suggests it might be...

APM vendors would very much like this. We do [unspeakable things with import-in-the-middle](https://github.com/DataDog/import-in-the-middle/blob/main/hook.js) to make it look similar to require-in-the-middle, and all because ESM loaders were unwilling at the time...

Probably related is that I had previously attempted to [add diagnostics_channel events to the module loading lifecycle](https://github.com/nodejs/node/pull/44340), which could have been patchable through subscribers. That ended up stalling though as...

If I'm understanding the spec right, we still have the problem of [import bindings being immutable](https://tc39.es/ecma262/#sec-createimportbinding), so patching the exports object would not work?

Would pre-link work? Basically we need to be able to get a reference to a current exported function or class and replace that export with another that calls the original...