admin icon indicating copy to clipboard operation
admin copied to clipboard

Transfer elastic/require-in-the-middle to the org

Open trentm opened this issue 1 year ago • 9 comments
trafficstars

Following on import-in-the-middle (IITM) being transferred to the nodejs org and discussion in today's Diagnostics WG meeting, this is a request to also move require-in-the-middle (RITM) from the Elastic org to the Node.js org. As with import-in-the-middle, this would be governed by the TSC, but delegated to the Diagnostics WG. The expectation is that there would be significant overlap in the maintainers of IITM and RITM.

require-in-the-middle is a fairly mature library for intercepting CommonJS module loading via require(...). It is widely used in the Observability/APM space -- OpenTelemetry, Elastic, Datadog (though I think they currently have a small fork), New Relic. Reasoning for wanting to donate this to a vendor-neutral org are the same as described for IITM.

/cc @nodejs/tsc @nodejs/diagnostics

Others, please indicate if you'd be interested in maintaining RITM.

trentm avatar Jun 27 '24 22:06 trentm

SGTM. 👍🏻

Qard avatar Jun 27 '24 22:06 Qard

+1

legendecas avatar Jun 28 '24 13:06 legendecas

I would be interested in helping maintain! Aside from the open issues are there any areas that require-in-the-middle is looking to improve/refactor in the near future?

AbhiPrasad avatar Jul 01 '24 05:07 AbhiPrasad

Thanks for opening this issue @trentm. I'd love to help maintain the module under the Node.js org

watson avatar Jul 01 '24 07:07 watson

I'm also happy to help out with this one. :slightly_smiling_face:

pichlermarc avatar Jul 01 '24 16:07 pichlermarc

I would be interested in helping maintain too!

timfish avatar Jul 05 '24 00:07 timfish

+1 from me in terms of the transfer

mhdawson avatar Jul 09 '24 17:07 mhdawson

This is open for three weeks. I'm reaching out to @trentm to finalize this.

legendecas avatar Jul 17 '24 08:07 legendecas

Still in the middle of internal process.

legendecas avatar Sep 04 '24 14:09 legendecas

Transfer has been done. https://github.com/nodejs/require-in-the-middle is there now.

trentm avatar Jan 29 '25 16:01 trentm

It appears I don't have write access to the new repo, so I can't merge PRs. What's the process to get that?

watson avatar Jan 30 '25 11:01 watson

[@watson]

It appears I don't have write access to the new repo, so I can't merge PRs. What's the process to get that?

I think you'll need to get on the https://github.com/orgs/nodejs/teams/import-in-the-middle-maintainers/members team. I don't have access to invite you. I think @bengl will as a "maintainer" of the team, and I assume @legendecas has admin access for the team.

trentm avatar Jan 30 '25 17:01 trentm

Created @nodejs/require-in-the-middle-maintainers to keep the repo running, we can define the new member process in https://github.com/nodejs/require-in-the-middle/issues/102.

legendecas avatar Jan 30 '25 18:01 legendecas