dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

Use unified Gitlab pipeline

Open randomanderson opened this issue 1 year ago • 3 comments
trafficstars

What does this PR do?

Motivation

Additional Notes

randomanderson avatar Jun 10 '24 20:06 randomanderson

Overall package size

Self size: 6.82 MB Deduped: 58.33 MB No deduping: 58.61 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.0.0 | 11.14 MB | 11.15 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 6.56 MB | | @datadog/native-iast-rewriter | 2.3.1 | 2.15 MB | 2.24 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Jun 10 '24 20:06 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.98%. Comparing base (a34a685) to head (10b4ec4). Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4397      +/-   ##
==========================================
- Coverage   95.85%   85.98%   -9.87%     
==========================================
  Files         105      252     +147     
  Lines        3451    11018    +7567     
  Branches       33       33              
==========================================
+ Hits         3308     9474    +6166     
- Misses        143     1544    +1401     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 10 '24 20:06 codecov[bot]

Benchmarks

Benchmark execution time: 2024-07-18 22:41:14

Comparing candidate commit 10b4ec453f844934b79816839b42537f1c674048 in PR branch landerson/one-pipeline with baseline commit d6be61d0e331eda7d89d864fcaba84908a736898 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

pr-commenter[bot] avatar Jun 20 '24 21:06 pr-commenter[bot]

@Qard These pipeline runs on every push. For k8s injection, the image is tagged with the commit sha. For OCI images, the version is the version from the repo + the pipeline id + the commit sha.

For releases, the git tag is used as the init image tag and the OCI image version.

I don't believe any of your current processes will be disrupted

randomanderson avatar Jul 24 '24 15:07 randomanderson

Ah, so triggering off github releases is how we get the official release builds? Is it desirable for this to be running on all pushes everywhere? That seems like a lot of unnecessary work. 🤔

In any case, as long as this doesn't disrupt our existing customer expectations from this, I think we're good. 🙂

Qard avatar Jul 24 '24 17:07 Qard

Ah, so triggering off github releases is how we get the official release builds? Is it desirable for this to be running on all pushes everywhere? That seems like a lot of unnecessary work. 🤔

@Qard Yes. We have automated tests that run as part of CI/CD. These builds are running on the Gitlab infra so cost is negligible

randomanderson avatar Jul 25 '24 15:07 randomanderson