Pujan Shah
Pujan Shah
@JmillsExpensify To inform, I am OOO until 27th May. Either we can reassign to the other C+ or else I will check post my holidays.
I think the last option from @bernhardoj's proposal of calling endSignOnTransition when exitTo isn't available looks good to me. 🎀👀🎀 C+ reviewed
# BugZero Checklist: - [X] **[Contributor]** Classify the bug: Bug classification Source of bug: - [ ] 1a. Result of the original design (eg. a case wasn't considered) - [X]...
Sorry for the delay, I will review the proposals today.
Usually `initiallyFocusedOptionKey` is a straightforward option which also consistent with other places but it won't work for all scenarios(`1. Reload and the context may not be available initially 2. When...
## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...
Only issue I am seeing is that there is some distance unit(km and ml) inconsistency after the rate selection and with the price in the preview. https://github.com/user-attachments/assets/c180ad6d-1c29-45ea-81da-f1611a353139
> Coming from [here](https://github.com/Expensify/App/pull/40793#issuecomment-2190915651), where I reviewed this PR #40793. If this is corresponding issue, can I get assigned to this? or is there separate issue +1, I have reviewed...
It works well for me too. @oblador Could you plz check one more time on your side? | Before | After Fix | | ------------- | ------------- | | |...
Gentle bump for recheck @oblador