App icon indicating copy to clipboard operation
App copied to clipboard

Animation to older messages are wrong and `New message` animation is also wrong

Open m-natarajan opened this issue 1 year ago โ€ข 3 comments

If you havenโ€™t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.65-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @rafecolton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713999231465699

Action Performed:

  1. Open the Desktop app in mobile sized view
  2. Scroll back to earlier in the chat
  3. Get a direct link to a comment
  4. Paste that link as a new message
  5. Click on the link from within the chat

Expected Result:

Should take to the old message with correct animation and clicking on New Message bubble should have correct animation

Actual Result:

Animation to older message is wrong and clicking on New Message there's a right-to-left slide animation that happens

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/9d0323e0-0c50-474e-9a65-ec9879486bfe

https://github.com/Expensify/App/assets/38435837/1d405eeb-f4c0-410f-b55b-2c4e58432f62

View all open jobs on GitHub

m-natarajan avatar Apr 26 '24 17:04 m-natarajan

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Apr 26 '24 17:04 melvin-bot[bot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Apr 26 '24 17:04 MelvinBot

I am able to reproduce consistently, fwiw.

rafecolton avatar Apr 26 '24 17:04 rafecolton

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Apr 29 '24 18:04 melvin-bot[bot]

Adding a LOW for vip-vsb and opening up to the community.

JmillsExpensify avatar May 01 '24 04:05 JmillsExpensify

Job added to Upwork: https://www.upwork.com/jobs/~01f4f1283f9f5001a1

melvin-bot[bot] avatar May 01 '24 04:05 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

melvin-bot[bot] avatar May 01 '24 04:05 melvin-bot[bot]

Please feel free to assign me when it's time for an internal engineer to review the proposal. (I don't do the chore currently, so I will not be auto-assigned.)

rafecolton avatar May 01 '24 20:05 rafecolton

@JmillsExpensify, @Pujan92 Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar May 07 '24 01:05 melvin-bot[bot]

@JmillsExpensify, @Pujan92 Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar May 07 '24 20:05 melvin-bot[bot]

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar May 08 '24 16:05 melvin-bot[bot]

@JmillsExpensify, @Pujan92 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar May 09 '24 18:05 melvin-bot[bot]

@JmillsExpensify @Pujan92 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar May 10 '24 18:05 melvin-bot[bot]

@JmillsExpensify, @Pujan92 10 days overdue. Is anyone even seeing these? Hello?

melvin-bot[bot] avatar May 13 '24 19:05 melvin-bot[bot]

Still waiting for proposals.

JmillsExpensify avatar May 15 '24 03:05 JmillsExpensify

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar May 15 '24 16:05 melvin-bot[bot]

@JmillsExpensify To inform, I am OOO until 27th May. Either we can reassign to the other C+ or else I will check post my holidays.

Pujan92 avatar May 17 '24 20:05 Pujan92

@JmillsExpensify, @Pujan92 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar May 21 '24 18:05 melvin-bot[bot]

Issue not reproducible during KI retests. (First week)

mvtglobally avatar May 22 '24 04:05 mvtglobally

Going to wait and see if this is non-reproducible next week, and then we can close.

JmillsExpensify avatar May 22 '24 06:05 JmillsExpensify

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar May 22 '24 16:05 melvin-bot[bot]

@JmillsExpensify @Pujan92 this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar May 24 '24 17:05 melvin-bot[bot]

@JmillsExpensify, @Pujan92 Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar May 27 '24 18:05 melvin-bot[bot]

Still waiting on proposals

JmillsExpensify avatar May 29 '24 17:05 JmillsExpensify

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar May 29 '24 22:05 melvin-bot[bot]

@JmillsExpensify, @Pujan92 Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Jun 03 '24 19:06 melvin-bot[bot]

Still waiting for proposals

JmillsExpensify avatar Jun 05 '24 05:06 JmillsExpensify

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar Jun 05 '24 16:06 melvin-bot[bot]

Issue not reproducible during KI retests. (Second week)

mvtglobally avatar Jun 05 '24 21:06 mvtglobally

@JmillsExpensify, @Pujan92 Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Jun 10 '24 18:06 melvin-bot[bot]