react-native-collapsible icon indicating copy to clipboard operation
react-native-collapsible copied to clipboard

Fix: Accordion content blinking

Open truph01 opened this issue 1 year ago • 4 comments

  • This PR will fix the issue https://github.com/oblador/react-native-collapsible/issues/473. We also encountered that bug in our project https://github.com/Expensify/App/issues/43397
  • Here is the result after the fix:

https://github.com/oblador/react-native-collapsible/assets/170341821/dd1d192a-2a3e-4b48-856a-da1e0e10c48e

truph01 avatar Jun 21 '24 08:06 truph01

@oblador Can you help review this PR once you have a chance? Thanks

truph01 avatar Jun 21 '24 08:06 truph01

Hi, thanks for your PR! When I tested there's still junk on Android (iOS looks fine from what I can tell):

https://github.com/oblador/react-native-collapsible/assets/378279/2f349c63-3ea1-4985-aac6-74d2410e1320

oblador avatar Jul 01 '24 22:07 oblador

@Pujan92 Can you reproduce the issue on Android after applying the fix? It works well from my side:

https://github.com/oblador/react-native-collapsible/assets/170341821/5e7921b0-b83e-4e18-a7d9-d2963a5da813

truph01 avatar Jul 02 '24 03:07 truph01

It works well for me too. @oblador Could you plz check one more time on your side?

Before After Fix

Pujan92 avatar Jul 02 '24 06:07 Pujan92

Gentle bump for recheck @oblador

Pujan92 avatar Jul 09 '24 08:07 Pujan92

Tried the example code with the functional component and was not able to reproduce the mentioned bug for android.

https://github.com/oblador/react-native-collapsible/assets/14358475/015d66eb-780c-484f-834b-c0898f6822be

Pujan92 avatar Jul 09 '24 19:07 Pujan92

@oblador Can you help review the PR? Thanks

truph01 avatar Jul 22 '24 09:07 truph01

@oblador Any update on the PR review?

Thx

truph01 avatar Aug 20 '24 11:08 truph01

Thanks @oblador for the review and merge :)

Pujan92 avatar Aug 28 '24 05:08 Pujan92

This broke initially open collapsibles

VNDRN avatar Jan 27 '25 15:01 VNDRN