PrinsFrank

Results 25 comments of PrinsFrank

Hi @szepeviktor, thanks for all the great PRs! I don't know if I agree with this one though, can you explain why this is an improvement? IMHO a strict check...

Thank you for your contribution @szepeviktor! I will look at this in the following days!

Sounds good! If you want to add a PR you're more than welcome!

Because of reviewer amount limitations in private repos in orgs this also results in unassigning the current reviewer on every push action (or in case of only updating on open...

I just managed to work around it for now by adding a condition to the job like this: name: 'Auto Assign' on: pull_request: types: [opened, reopened] jobs: add-reviews: if: github.event.pull_request.requested_reviewers.*.name...

Had the same issue in a private repo run, different casing was indeed the problem in my case; ``` # A list of reviewers to be added to pull requests...

@matthew-inamdar This fix allows us to use the package, can you please merge this?

@matthew-inamdar Yes, that would suffice!

@matthew-inamdar Thinking about my previous comment, adding a ReturnTypeWillChange attribute will be a bigger change than adding return type as it will drop support for any PHP version below 8.1....

This PR is now obsolete as #55 as discussed above has been merged and released in 2.9.0. @judgej or @matthew-inamdar this PR can be closed then, right?