auto-assign-action
auto-assign-action copied to clipboard
"Review can not be requested from author"
4 developers work on a single repo. If one developer creates a PR, and he is in the "reviewers" list, action fails with "Review can not be requested from author"
.
Expected behavior: Author is skipped, all other users added as reviewers.
Actual behavior: 0 reviewers added.
Config:
# Set to true to add reviewers to pull requests
addReviewers: true
# Set to author to set pr creater as assignee
addAssignees: author
# A list of reviewers to be added to pull requests (GitHub user name)
reviewers:
- deva
- devb
- devc
- devd
# A number of reviewers added to the pull request
# Set 0 to add all the reviewers (default: 0)
numberOfReviewers: 0
# A list of keywords to be skipped the process that add reviewers if pull requests include it
skipKeywords:
- wip
Hi @Warchant ! Thanks for reporting the problem.
The message Review can not be requested from author
is shown, when the PR author is added as a reviewer to the pull request. This behavior is specification on GitHub.
Auto Assign Action excludes the PR author from reviewers. I checked your repository. I have a concern that a format of reviewer list may have caused the exclusion process to fail.
https://github.com/VeriBlock/alt-integration/pull/39
I want you to try modifying to Warchant
from warchant
in the reviewers' list.
Usernames must be handled in lowercase on the application. I think to need to fix it.
Had the same issue in a private repo run, different casing was indeed the problem in my case;
# A list of reviewers to be added to pull requests (GitHub user name)
reviewers:
- deva
- devb
- devc
- devd
# A number of reviewers added to the pull request
# Set 0 to add all the reviewers (default: 0)
numberOfReviewers: 0
where the user that commits has a username "Deva" results in this behaviour. Changing it to:
# A list of reviewers to be added to pull requests (GitHub user name)
reviewers:
- Deva
- devb
- devc
- devd
# A number of reviewers added to the pull request
# Set 0 to add all the reviewers (default: 0)
numberOfReviewers: 0
Fixes the issue.
As all other username functionality on github is case insensitive this is counter-intuitive and I had to come here to see this as well, maybe this can be changed to accept any case variant?