Prepmachine4
Prepmachine4
I am interested in this issue, can you assign it to me?
Does this feature need to be added? I have proposed a PR.
> Hi, are you still working on this? Add a new interface to cache is not a proper way, please get it from snapshot. I have stopped working in this...
> You just need to find the place where the controller last modified the status in these two related places and make the changes. `status.State.Phase = vcbatch.Completed` `status.State.Phase = vcbatch.Failed`...
I tested the metrics, and they were in line with expectations.
> squash the commit to one If i squash the commit to one, it seems like I need to re-create a PR, or is there another way?
> > > squash the commit to one > > > > > > If i squash the commit to one, it seems like I need to re-create a PR,...
> > Thanks for you contribution! It changed a lot cause vc controller also introduced metrics. > > What I want to say is that can we just put all...
ok, I will change the code again.
> > ok, I will change the code again. > > Okay, I'm just putting my two cents in here. My reasoning is solely based on the approaches taken by...