volcano icon indicating copy to clipboard operation
volcano copied to clipboard

feat: session struct add vcinformer and vcClient field

Open Prepmachine4 opened this issue 1 year ago • 5 comments

fix: #3554

Prepmachine4 avatar Aug 06 '24 14:08 Prepmachine4

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign hwdef You can assign the PR to them by writing /assign @hwdef in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Aug 06 '24 14:08 volcano-sh-bot

we'd better use snapshot. cc @Monokaix

lowang-bh avatar Aug 07 '24 01:08 lowang-bh

we'd better use snapshot. cc @Monokaix

But it will also occupy more cahce.

Monokaix avatar Aug 08 '24 02:08 Monokaix

Hi, are you still working on this? Add a new interface to cache is not a proper way, please get it from snapshot.

Monokaix avatar Sep 24 '24 09:09 Monokaix

Hi, are you still working on this? Add a new interface to cache is not a proper way, please get it from snapshot.

I have stopped working in this issue, so is this PR need to be closed?

Prepmachine4 avatar Sep 25 '24 06:09 Prepmachine4

@Prepmachine4: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Nov 02 '24 09:11 volcano-sh-bot

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Feb 01 '25 01:02 stale[bot]