Pranav Yadav

Results 52 comments of Pranav Yadav

@ferBonnin I can help with this one; if not already assigned to anyone :)

@ferBonnin I can help with this one; if not already assigned to anyone :) PS: PR for: Parsing Instructions rephrase: `#6130` is opened already & is ready to review &...

@balazsorban44 I would like to help w/ this one; if it's not assigned to anyone already :) PS: I think this issue has something to do w/ following lines of...

@cipolleschi as mentioned in the issue, I've Extracted the content of the `tryParse` ([Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/modules/index.js#L292-L337), [TypeScript](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/modules/index.js#L306-L351)) lambda into a proper `parseObjectProperty` fn into the `parsers-commons.js` file. - Have prepared some tests...

Done suggested changes! @cipolleschi Though, not sure about these errors; yarn run flow o/p 🔽 ... ... --- yarn jest react-native-codegen o/p 🔽 ...

On it. Thanks for brief instructions. Btw, had overviewed the PR you mentioned; earlier today, and was able to get around those :)

@cipolleschi Flow is now `#00ff00`. But, `react-native-codegen` is failing `#ff0000`

@cipolleschi Tests Results yarn jest react-native-codegen yarn test yarn test-ci

@cipolleschi added tests for `isObjectProperty` and `parseObjectProperty` fn 's :) PS: rebased on main as well. _signing off.. have exams tomorrow; need to study hahaha, will see this afterwards if...

@cipolleschi pinging you; in case you missed previous comment :)