accessibility-insights-web icon indicating copy to clipboard operation
accessibility-insights-web copied to clipboard

Links to Design Pattern in Assessment take you to main ARIA APG page

Open ferBonnin opened this issue 3 years ago • 1 comments

Describe the bug

The design pattern links no longer take you to the design pattern page

To Reproduce Steps to reproduce the behavior: Got to Assessment > Custom widgets > Design pattern on a page with custom widgets, note that the links we have in the list of instances no longer take you to the design pattern page. Instead they take you to the landing page with all design patterns

CodePen repro example

Expected behavior

Context (please complete the following information)

  • OS Name & Version: Windows
  • AI-Web Version & Environment: Insider MV3 2.35.0
  • Browser Version: Chrome
  • Target Page: any

Did you search for similar existing issues?

yes

Additional context

There is a new site for WAI ARIA practices that is redirecting the old link to this.

ferBonnin avatar Oct 10 '22 17:10 ferBonnin

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

ghost avatar Oct 12 '22 15:10 ghost

we should change the links in all requirements that point to design patterns

ferBonnin avatar Oct 24 '22 23:10 ferBonnin

@ferBonnin I can help with this one; if not already assigned to anyone :)

PS: PR for: Parsing Instructions rephrase: #6130 is opened already & is ready to review & merge.

PPS: re: this issue; Can you please pin here; the correct link(s) to design patterns landing page?

Pranav-yadav avatar Oct 27 '22 16:10 Pranav-yadav

Thanks @Pranav-yadav assigning this to you! This is the landing page link, we would need to point to the right subpage for each pattern. For example for combobox the current link is: https://www.w3.org/TR/wai-aria-practices-1.1/#combobox the new link should be: https://www.w3.org/WAI/ARIA/apg/patterns/combobox/

Thanks for the parsing instructions rephase, our team will review and merge!

ferBonnin avatar Oct 27 '22 17:10 ferBonnin