Porter Nan

Results 8 comments of Porter Nan

Thanks for bringing this up in standup - I guess the current problem is we can't 100% determine if that is a PSTN call or not only by locator -...

Hi, thanks for reporting the issue, for now callComposite.js bundle only support groupId scenario, we might add teams meeting and more scenarioes to it in the future, but if you...

> Are we able to splti this PR into two -- one to just bump the calling SDK version and then one to add upport for `TeamsCall`? > > This...

> Did a quick pass, trying to wrap my head around the agent inheritance, I'm concerned about the runtime type checks that are happing (`isACSCallAgent`) coupled with the `any`s and...

Thanks for opening this issue! Looking at our repo code, looks like we are doing some permission query in the file packages/react-composites/src/composites/CallComposite/utils/Utils.ts Will open a bug and doing follow up...

Created a follow-up item to refactor implementation of adapter as we discussed @prprabhu-ms https://skype.visualstudio.com/SPOOL/_workitems/edit/2894791 Will pick it up a bit later once we finish main chunk of CTE

yea... I usied that event, but it feels that event only triggered when mouse is on a item, lemme double check if I just got a wrong memory

Just validated that and it works! Thanks for sharing that code snippet, there is one more interesting question comes up now, when I call timelineInstance?.addCustomTime(event.time); it create a dragabble line...