communication-ui-library
communication-ui-library copied to clipboard
Azure
remove the rejoin button from end call screen in calling composite
What
Remove the end call screen's rejoin call button
Why
Better supports the locator method of starting a PSTN or 1:N call, should the users change in the call the locator would not update. the issue here being then that when they action the rejoin call button they will redial the original participants of the call. instead of the composite having to update the locator on each new participant change (leave or join) we rely on Contoso to make this button.
This is probably a breaking UI change so please leave your thoughts about this.
How Tested
Storybook URL https://60c7ae6891f0e90039d7cd54-egzydhstne.chromatic.com/
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Chat bundle size is not changed.
- Current size: 5193071
- Base size: 5193071
- Diff size: 0
CallWithChat bundle size is decreased✅.
- Current size: 5450541
- Base size: 5450706
- Diff size: -165
Calling bundle size is decreased✅.
- Current size: 5065924
- Base size: 5066089
- Diff size: -165
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.
Thanks for bringing this up in standup - I guess the current problem is we can't 100% determine if that is a PSTN call or not only by locator - since this could be a future problem as well: Is it possible to add a new property in adapter state named isPSTNCall?
If someone call the PSTN number - even it is a group call, the flag will be permanently changed - then we can always leverage this flag for multiple behaviors in the future (including dialog three dots button or so?)
Storybook URL https://60c7ae6891f0e90039d7cd54-hrwmropdbn.chromatic.com/
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.