beam icon indicating copy to clipboard operation
beam copied to clipboard

[yaml] Add use cases for Enrichment transform in YAML

Open reeba212 opened this issue 1 year ago • 7 comments

  1. Added a simple bigtable enrichment example
  2. Added an end to end use case that demonstrates how spanner IO and enrichment transform coupled with other YAML transforms can be used in a real world setting

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

reeba212 avatar Aug 22 '24 18:08 reeba212

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python. R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Aug 22 '24 20:08 github-actions[bot]

Reminder, please take a look at this pr: @damccorm @ahmedabu98

github-actions[bot] avatar Sep 05 '24 12:09 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python. R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Sep 09 '24 12:09 github-actions[bot]

Reminder, please take a look at this pr: @liferoad @johnjcasey

github-actions[bot] avatar Sep 16 '24 12:09 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python. R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Sep 19 '24 12:09 github-actions[bot]

@Polber what are next steps on this PR?

@reeba212 it looks like some precommit checks are failing - would you mind taking a look? At a glance, I see:

  1. the RAT license check is missing - this is because some files are missing the Apache license
  2. Lint/format checks are failing - could you try https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-LintandFormattingChecks
  3. test_bigtable_enrichment_yaml seems to be failing

damccorm avatar Sep 19 '24 14:09 damccorm

@Polber @reeba212 friendly reminder to please take a look at this one when you have a chance

damccorm avatar Oct 03 '24 15:10 damccorm

You should be able to rebase on master now and pull in the EnrichmentTransform changes

Polber avatar Oct 22 '24 17:10 Polber

Reminder, please take a look at this pr: @tvalentyn @Abacn

github-actions[bot] avatar Oct 30 '24 12:10 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python. R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Nov 04 '24 12:11 github-actions[bot]

R: @Polber

@Polber @reeba212 what are next steps here?

damccorm avatar Nov 04 '24 13:11 damccorm

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Nov 04 '24 13:11 github-actions[bot]

Failing tests are unrelated to the PR, merging - thanks!

damccorm avatar Dec 16 '24 14:12 damccorm