Veselyev Aleksandr comments

Results 4 comments of


                                            Veselyev Aleksandr

errer: tramsform Model to Torch Script

`0.7.0` version has the same issue

Hello! Can you tell me how to use face_detector?

Hi! mtcnn face detector is used (https://github.com/timesler/facenet-pytorch) model is instantiated here https://github.com/Podidiving/lgsc-for-fas-pytorch/blob/337889ad75a28ff6fa52242803064d35ff2a4810/src/datasets/datasets.py#L52 So, in order to create model, you need to define `face_detector` dict in [train_config.yml](https://github.com/Podidiving/lgsc-for-fas-pytorch/blob/master/configs/train_config.yml), for example: ``` face_detector:...

Python formatting and fix typos

Great idea to clean up code! I have a couple of suggestions: - add isort checking - add linting tool (e.g. flake8) - create `Makefile` with targets to automatically reformat/lint...

Have you compared your results with those of the paper

Hi! Sorry for long response. I've only had access to SiW dataset. I've tried Protocol 1 and my results are slightly worse, than author's resluts. I'm still working on this....