babyagi icon indicating copy to clipboard operation
babyagi copied to clipboard

Python formatting and fix typos

Open giorgiop opened this issue 1 year ago • 4 comments

giorgiop avatar Apr 05 '23 19:04 giorgiop

What did you use as a formatter? Was thinking of adding black or something similar

davidbyttow avatar Apr 06 '23 14:04 davidbyttow

Good cleanup, unfortunately too many other things got merged. Can you rebase and resolve conflicts and I'll merge?

francip avatar Apr 08 '23 06:04 francip

What did you use as a formatter? Was thinking of adding black or something similar

yes that was black

giorgiop avatar Apr 08 '23 13:04 giorgiop

Great idea to clean up code! I have a couple of suggestions:

  • add isort checking
  • add linting tool (e.g. flake8)
  • create Makefile with targets to automatically reformat/lint all the code before contributing
  • update Readme (contributing section), something like "format your code before you commit it"
  • (Optionally) make setup.cfg file to introduce custom code style. E.g. I think that default line lengths can be extended a little bit (let's say max-line-length=100 or something like that)

Podidiving avatar Apr 15 '23 08:04 Podidiving