Playtester

Yes, based on kRO. Divine Pride is correct on all your reports, though. Familiar and Scorpion are not aggressive and Hornet doesn't have assist. Where does Divine Pride have incorrect...

Nice implementation! You even went ahead and expanded unitsetting with a new parameter. =o

My "sources" are always from testing on Aegis myself, don't really trust external resources. Also you need to look into the linked issue to see what I actually tested. I...

v5[25].baseclass_0.m_skillName.baseclass_0 is supposed to be job level then? Kinda weird. I still want to test ingame to make sure, though.

Tested Adoramus Level 1, Job Level 50: vs 0 Mdef: 6/20 succses vs 50 Mdef: 8/20 success MDEF clearly doesn't reduce the chance, will correct that on rA. It's wrong...

Here you go: https://github.com/rathena/rathena/commit/1812fddc2936e76e6a07fc01985dec9405c6d402

Yeah, actually the way we implemented GTB on both rAthena and Herc is completely wrong. The only thing that's in Aegis (pre-re) is that if you are magic immune and...

Yes either this, or we do it like Aegis does for Freeze and Stone and push the information "isSpell" (on our emulators that would be type==magic) into sc_start. We just...

There are three skills that need to be verified: 256,9,6,16,0,0x1,0,5,1,yes,0,0x200,0,none,0,0x0, CR_PROVIDENCE,Resistant Souls 383,0,6,4,0,0x3,-1,10,1,yes,0,0,0,weapon,0,0x0, SN_WINDWALK,Wind Walker 2350,0,6,4,0,0x3,7:8:9:10:11,5,1,yes,0,0,0,none,0,0x0, WA_SWING_DANCE,Swing Dance If anyone could test these on Aegis (or official servers if you...

Fixed it on rAthena now: https://github.com/rathena/rathena/issues/5682 https://github.com/rathena/rathena/commit/ae4e2b9cbad93e229103bc9abaa4cbfde4967439 Aleos found an easy way to fix it. :-)