Hercules icon indicating copy to clipboard operation
Hercules copied to clipboard

Published 20 hours ago • verified publisher icon HerculesWS

Meteor Storm Update

Open dastgirp opened this issue 8 years ago • 7 comments

  • Official implementation of Meteor Storm behavior -- It deploys all units directly at castend -- Each unit has a different expiration time -- On the last interval of a unit the meteor will appear -- When the unit expires, it will deal damage -- If the unit gets removed at any time, no meteor will appear and no damage will be dealt
  • It is now easily possible to configure Meteor Storm behavior via database files, no more extra coding required
  • Fixed Meteor Storm sometimes dealing damage even though no meteor appeared
  • Fixed Meteor Storm being able to hit through walls when the caster has moved in the meantime

Credits: Playtester (https://github.com/rathena/rathena/commit/1365d9418e96c028cad903fe5cab8edb7c8ae0fc)

dastgirp avatar Mar 29 '16 12:03 dastgirp

:+1:

kyeme avatar Mar 29 '16 13:03 kyeme

Nice implementation! You even went ahead and expanded unitsetting with a new parameter. =o

Playtester avatar Mar 30 '16 08:03 Playtester

This change is Reviewable

HerculesWSAPI avatar Mar 20 '18 22:03 HerculesWSAPI

@dastgirp can you update this? Thank you.

kyeme avatar Oct 22 '19 08:10 kyeme

why was this never implemented? it looks solid o.o

this should maybe be rereviewed? @4144 @dastgirp

Gardosen avatar Jun 16 '21 19:06 Gardosen

why was this never implemented? it looks solid o.o

this should maybe be rereviewed? @4144 @dastgirp

, I will do a rebase in upcoming days and let's hope it gets reviewed this time.

dastgirp avatar Jun 17 '21 02:06 dastgirp

This PR seems a good candidate for rebase.

MrKeiKun avatar Aug 05 '21 10:08 MrKeiKun