Hercules rA Merges

I am just gathering commits, so that it's easy to track it down and merge (and get inputs from others)

rA commits to be merged:

[x] Meteor Storm - https://github.com/HerculesWS/Hercules/pull/1230
[x] Volcanic Ash Effect - https://github.com/HerculesWS/Hercules/pull/1231
[x] Chemical Protection - https://github.com/HerculesWS/Hercules/pull/1232
[x] Defense overflow Exploit - https://github.com/HerculesWS/Hercules/pull/1233
[x] Power Swing - https://github.com/HerculesWS/Hercules/pull/1235
[ ] SP Damage by Vellum - https://github.com/rathena/rathena/commit/6dc437fd08c961cc8caa86e55b9853e541ba63fe / https://github.com/rathena/rathena/commit/e071256247a05084bf2a699e736eb0e19423396a
[ ] Monster Log - https://github.com/rathena/rathena/commit/0bd337d9ad9cc1dbebb93f2f1ebbde1b1de8ba6a
[ ] Knuckle Damage - https://github.com/rathena/rathena/commit/0bd337d9ad9cc1dbebb93f2f1ebbde1b1de8ba6a
[ ] Fire Expansion - https://github.com/rathena/rathena/commit/7f7af2e97ec52df96e4f1b2d17779e816685ccdc
[x] MvP Exp Message - https://github.com/rathena/rathena/commit/85749e84b91087960e868e30a7a052b0c0cdce5b
[ ] Snap - https://github.com/rathena/rathena/commit/b5de854b90353f2decf83a95fba8c19fbe641fb7
[ ] Fear Status - https://github.com/rathena/rathena/commit/fbb8edba3949035b10fa1eaf112a2e2319c2ae57
[ ] Skill Bypass - https://github.com/rathena/rathena/issues/984 (#841)
[ ] WOE TE - https://github.com/rathena/rathena/commit/6aed7e0245cf7e54e1dde2ccb042fac475274489
[ ] No Costume Mapflag - https://github.com/rathena/rathena/commit/23b271c9582c5c5e1ab60b8a356facd69e90f905
[ ] Eclage Skill Animation - https://github.com/rathena/rathena/commit/0feabf30cee1c3cdf11de52d1ac3a5b3ca7536fc
[x] Stat Reduce Pot -https://github.com/rathena/rathena/commit/51ef9118a8dce1c70fcd22a16ccdc4aad894f50d (#2483 / #2246)
[ ] Status Icons - https://github.com/rathena/rathena/commit/371f619cb4f3ba37df4afe16d60a387ebe8c1142
[x] Juperos Quest - https://github.com/rathena/rathena/commit/c488268d8c2fa74e1d16daf0c04a6bf2d36e2350
[x] GX Poison Duration - https://github.com/rathena/rathena/commit/72b61d742fd8d0c27f97e25fa8a255ec58740550
[x] Voice of Siren Duration - https://github.com/rathena/rathena/commit/f7a276ec7389389b6b56653ad87b21eb937aace6
[x] Swing Dance ASPD Bonus - https://github.com/rathena/rathena/commit/b99114c0cedaf9218bcbc0371819cf12256d4527
[ ] Updated HT_BLASTMINE and HT_CLAYMORETRAP renewal behavior - https://github.com/rathena/rathena/commit/b99114c0cedaf9218bcbc0371819cf12256d4527
[x] @reloadnpc - https://github.com/rathena/rathena/commit/9c2026d ** Non rA Merges ** (#2476)
[ ] Eden NPC's

Anyone is welcomed to list more commits List can be expanded/edited

Mar 29 '16 14:03 dastgirp

@Jedzkie @Michieru @kyeme

[ ] Damage against Skills : https://github.com/rathena/rathena/commit/989a2525ecfd63bbed76da615020042726af0284
[ ] Decrease Agi - https://github.com/rathena/rathena/commit/1ca9fb58f21bd7ea3a5ea1b6f6de1b22cc086a60
[ ] Epicleses - https://github.com/rathena/rathena/commit/a021829cda13523009143d7794d78c402633aa90
[ ] Monster Walk - https://github.com/rathena/rathena/commit/718e4785ae67d75116030a535967d1c18a181098 / https://github.com/rathena/rathena/commit/78419baa76657c383112babfc7633b57c5786482
[ ] Arrow Shower - https://github.com/rathena/rathena/commit/aa6a1110bd6210c42b0159574d205c66516dc0ea
[ ] Damage - https://github.com/rathena/rathena/commit/a6f73a6227bc9158127a7544acdb27acbfdc9651
[ ] Tiger Cannon - https://github.com/rathena/rathena/commit/0fb78d45b7054563ce9017c607aba7feb18cea70
[x] Stun - https://github.com/rathena/rathena/commit/80e026433f61aaa43b6ef061537c2ef34443662a
[ ] Line of Sight - https://github.com/rathena/rathena/commit/7906f0a3ff3742bb519b19b0cadbca9db0d35b32
[ ] Monster Mode - https://github.com/rathena/rathena/commit/ecb01c44f4465e7716606a25966ed33b3e6e5c63 / https://github.com/rathena/rathena/commit/2b7eb9f523f043dc29e5dc20f19a1f9f2e45d578
[ ] Some Skills - https://github.com/rathena/rathena/commit/61a48b9b0bb93b30b5985256540384d86448d32b

^ Any Comments upon this?

List can be expanded/edited

Mar 29 '16 14:03 dastgirp

Need confirmation whether this happen with us:

[x] Robe Disappearing - https://github.com/rathena/rathena/commit/0664fac2985a3a3138d8cca88b10fa25568d2673 ( We Already Have it, confirmed by @kyeme)
[x] Instance - https://github.com/rathena/rathena/commit/15d27a4ad91ef74423fbe60fef7916b366430c89
[ ] Font Clearing - https://github.com/rathena/rathena/commit/074bdded0979bb503288c02ec47cc5498da4023e

@Jedzkie

List can be expanded/edited

Mar 29 '16 14:03 dastgirp

Need to be discussed whether this should be merged

[ ] Dual Exploit - https://github.com/rathena/rathena/commit/c6ed8a4f92a143eca9ddc1c2161f88c1db9f70f4
[ ] adopt command - https://github.com/rathena/rathena/commit/0f5b6db8139d78da17587406d1cee45c7954b2ab
[x] macro name change - https://github.com/rathena/rathena/commit/ed7157c80b0da86aa81d3cfee5e9b9679938b4e2

Mar 29 '16 14:03 dastgirp

Robe Disappearing I can't reproduce using 2015-05-13client

Mar 29 '16 14:03 kyeme

Duel Exploit - rathena/rathena@c6ed8a4 Is this it? https://github.com/HerculesWS/Hercules/commit/aa9360cf69c30d26d7333b0c6c952b02b99bcba1

Mar 29 '16 14:03 kyeme

@kyeme, it's something different, it would clear all units(by skills) casted by players while entering/leaving the dual. Here's what playtester quoted

The atcommand "duel" changes what kind of "target" you are for others, so you are basically brought to a different plane with it. It is quite similar to moving maps, yet it's lacking all the processing that should come at changing maps like removing ground effects, stopping timerskills and checking the units you leave and enter.

This allows for huge exploits as you can completely mess up the server processing. I won't go into details here, but it allows you to get certain buffs and invincibilities pratically forever

Mar 29 '16 17:03 dastgirp

Damage against Skills -we already have this..and as I remember kyeme help me to list skills that hit ground skills...

Decrease Agi -I don't know where they get there sources but according to aegis mdef doesn't have any factor to adoramus effect

overall if its regarding skills and re mechanics I totally do not trust there sources..

Mar 29 '16 23:03 malufett

My "sources" are always from testing on Aegis myself, don't really trust external resources. Also you need to look into the linked issue to see what I actually tested. I always document all my tests.

Regard Duel Exploit: Herc already had this fixed by making duel not being affected by effects that effect "all", so it would not be exploitable with dances, safety wall and pneuma anymore. But I still recommend to just treat @duel just like you treat moving on a cell or changing maps and check all the new and ending effects at that point.

Regarding Decrease Agi: Hmm looking at the related issue I created: https://github.com/rathena/rathena/issues/1067 I did test this with Decrease Agi, but I'm not sure if I tested Adoramus vs MDEF anymore. Didn't write it in the issue! Would warrant another check.

Mar 30 '16 08:03 Playtester

I understand....according to this there is no mdef associated with the chances...

Mar 30 '16 10:03 malufett

v5[25].baseclass_0.m_skillName.baseclass_0 is supposed to be job level then? Kinda weird.

I still want to test ingame to make sure, though.

Mar 30 '16 11:03 Playtester

Erm, what's this->baseclass_0.baseclass_0.baseclass_0? Can the structs/class definitions there be trusted at all?

Mar 30 '16 11:03 MishimaHaruna

@Playtester @MishimaHaruna "v5[25].baseclass_0.m_skillName.baseclass_0" yes it is the base job level "this->baseclass_0.baseclass_0.baseclass_0" it is the class for target or the once casted with adoramus..

I just did a quick peek so some variables are not well named or organized..but the process or programming flow is the same...if master Yommy <3 will be the one doing this it is more cleaner to look..:)

Mar 30 '16 12:03 malufett

@malufett function name please? i will check it.

Mar 30 '16 12:03 hemagx

Tested Adoramus Level 1, Job Level 50: vs 0 Mdef: 6/20 succses vs 50 Mdef: 8/20 success

MDEF clearly doesn't reduce the chance, will correct that on rA. It's wrong on Herc too.

Mar 30 '16 15:03 Playtester

Here you go: https://github.com/rathena/rathena/commit/1812fddc2936e76e6a07fc01985dec9405c6d402

Mar 30 '16 15:03 Playtester

@hemagx CPC::AB_ADORAMUS() btw can you share to me your IDA options..:)

Mar 30 '16 23:03 malufett

I just use ida6.1 nothing special Will check after I finish rescue my old hard disk

On Thu, Mar 31, 2016 at 01:24 malufett [email protected] wrote:

@hemagx https://github.com/hemagx CPC::AB_ADORAMUS() btw can you share to me your IDA options..:)

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/HerculesWS/Hercules/issues/1234#issuecomment-203679505

Mar 31 '16 06:03 hemagx

if ( GetServerRandom(0, 20000) % 100 < this->m_characterInfo.joblevel / 2 + 4 * in_skilldata->skLevel )

so i believe it's correct. :) no mdef associated

Mar 31 '16 19:03 hemagx

@dastgir issue https://github.com/HerculesWS/Hercules/issues/841

https://github.com/rathena/rathena/issues/984

Apr 27 '16 04:04 kyeme

Checked off the ASPD Bonus because it seems we already have it https://github.com/HerculesWS/Hercules/blob/master/src/map/status.c#L6130

Thanks for the help @Asheraf

Mar 13 '17 21:03 FlippAcademy

Hercules Hercules copied to clipboard

rA Merges

Hercules
Hercules copied to clipboard