Pixelik comments

Results 15 comments of


                                            Pixelik

define destination using CSS selector instead of element Id

If you want current usages to continue working in a subsequent release then I'll need to leave `config['ember-basic-dropdown'].destination` to its current behaviour, i.e. it will continue to only accept ids...

define destination using CSS selector instead of element Id

Hi @cibernox the PR is ready but I don't have rights to push

ember-moment is trying to import from ember-cli-moment-shim but that is not one of its explicit dependencies Error thrown while using Embroider compat build

I'me having a similar (or actually the same) issue with Ember 4.12 and embroider-safe: https://github.com/embroider-build/embroider/issues/1598#issuecomment-1718232147

Uncaught Error: Assertion Failed: [BUG] Missing action with Ember v4.11

Same thing on Ember 5.4

`Error: "EmberObject.create no longer supports.."` on Ember-4.12 addon - ONLY during embroider-safe scenario

👀 If I change `ember-cp-validations/addon/-private/options.js ` from: ``` export default class Options { constructor({ model, attribute, options = {} }) { const optionKeys = keys(options); const createParams = { [OPTION_KEYS]:...

breaking: upgrades to Ember 5.3 / drops Ember 4.4

Thank you @fsmanuel 🙏

breaking: upgrades to Ember 5.3 / drops Ember 4.4

did you get a chance to have a look @fsmanuel ? 🙂 it would be nice to make a v6 release asap 🙏

breaking: upgrades to Ember 5.3 / drops Ember 4.4

@MelSumner do you think we could merge this and make a release? 🙏

breaking: upgrades to Ember 5.3 / drops Ember 4.4

Hello @fsmanuel, thanks for the review 🙏 Could you please add commit/code suggestions instead ? I'm not sure I understand what changes you'd like me to make. Please note that...

chore: makes it Ember 5 compatible

Given that ember-infinity is still on Ember 3 there is apparently a lot more upgrades and probably refactoring to be done for this PR to work: