PieterPenninckx

Results 17 comments of PieterPenninckx

`rsynth` has a very similar problem. The current version of `rsynth` solves this by not giving the API user the option to choose the buffer type (i.e.: it is not...

Ok, the comment above is probably not 100% clear (I wrote it in a rush). The gist is that `rsynth` has a similar problem and that I've found a way...

> Should the in-place-compatible port types be the default? I think it's best to not have a "default" that can be overridden, but to just always "ask to choose". The...

Cool, thanks for the effort! Edit: I didn't see it's already marked as "Draft". I'm starting to try to understand your PR and I will probably have to come back...

Thanks for explaining. If I get it correctly, the important part is in the implementation of the `Deref` trait: ``` impl Deref for OutputPort { type Target = T::OutputPortType; fn...

FYI: there's also [this branch](https://github.com/johannes-mueller/rust-lv2/tree/lv2-options); it may serve as inspiration. Edit: this PR seems to be much more complete.

This is actually the first more-than-superficial review I'm doing for this crate. I've found some things that are unrelated to this PR, I'm fixing these [in my fork](https://github.com/PieterPenninckx/rust-lv2/commits/develop).

> I've put fixes and reworks on the [atom-soundness](https://github.com/RustAudio/rust-lv2/tree/atom-soundness) branch. It looks like you've found much more than I have. I'll just document issues in my fork without an effort...

I had hoped to add support for LV2 in `rsynth` this week, which would give me enough background knowledge to review this PR, but alas... I'm afraid I won't be...

Hi @mxmilkiib , thanks for pointing me to this! I think adding this would need some redesign, so it's good that I know about this early. Do you already have...