Philipp van Kempen

Results 150 comments of Philipp van Kempen

> Build Windows Installer with InnoSetup to bundle JRE with (only if really required, as it requires 32bit wine and does not support much distributions. Have a look at: https://github.com/TheBoegl/innosetup-docker)...

> [Docker] We could also add docker support for both client and server (Maybe separate issue?). Yes, separate issue please. > [WINDOWS] https://stackoverflow.com/questions/49651902/how-to-get-the-jre-to-bundle-with-launch4j Maybe this could solve the problem with...

> For the version consistency, I think we could migrate to version format like 2.1.0.0, which should be usable in all settings. I already wanted to mention this when I...

The changelog in the Release notes are intended to help drafting the actual release notes by having the commit messages as an reference.

I think this would require huge changes to the codebase. I do neither have time or interest in implementing it. Sorry.

Feel fee to try it out.

Quick workaround for now: `ACTIONS_ALLOW_UNSECURE_COMMANDS: true` @pehala Are you interested in using Environment files instead of `set-env` for performing the same job?

`ACTIONS_ALLOW_UNSECURE_COMMANDS: true` works fine for me and does not need to be replaced.

I would prefer the option of using GitHub actions for publishing the image. `mvn install` should not require Docker. Also I do not think that a custom maven command is...

@pehala Do we want to publish the Docker Image to Docker Hub? Are there any concerns against that in terms of copyright issues?