Philippe Cholet

Results 143 comments of Philippe Cholet

The issue here is that to get a `Result`, we need to consume (at least partially) the iterator and therefore collect the intermediary `Ok` elements, which necessarily allocate. Something like...

I'm doing AoC as well and I sure do `+1` as much as anybody. But do that would clash with `core::iter::Iterator::enumerate` which we won't do here. Obviously, we could change...

That's like `start.zip(self)` (I therefore edited my previous comment). The downside of your function is that we can't put it in a trait because of the opaque type of the...

I'm not sure but I feel like a "zip" version would be less efficient than `.enumerate.map`?

Well they added `enumerate` and some of them probably thought of an alternative start than 0 so I suspect they would not be interested, but it's only a guess. Coming...

Currently, this crate uses "stable Rust" only and our MSRV does not allow us to use "const generics". "Const generics" might be usable in a few months (I guess I'm...

From https://github.com/rust-itertools/itertools/pull/814#discussion_r1439867108 > In libcore, `fold` is usually specialized using `try_fold` specializations alongside with `NeverShortCircuit` which surely won't be public forever so I thought that we would copy it at...

@phimuemue What do you think on this matter? --- _What would be the inconvenients of using Rust nightly_ (for one feature only)? As we would be able to use the...

As a maintainer or not, I certainly would like to customize the hasher too. Related to #462 which contains comments written by phimuemue that I agree with and that could...

Instead of copy/paste, if we were to use the nightly unstable feature related to `Try` (just wondering) then "what would be the inconvenients?" was my question.