Philippe Cholet

Results 143 comments of Philippe Cholet

I'm gonna make an issue about fusedness to see opened issues and PRs related to it, clarify the situation (like make a guideline) and eventually make a TODO list about...

I rebased on master and added 4 commits: 1. Is there a reason to prefer `Take` over `Skip`? As `Skip` is simpler defined! 2. I don't see how we should...

I think this should be fixed once RFC2845 (https://github.com/rust-itertools/itertools/issues/702#issuecomment-1708525001) is implemented, as one should then shadow the other.

Currently, we can do `it.into_grouping_map().product();` but we can't have a generic map. ```rust let my_map = HashMap::new(); let my_map = HashMap::with_capacity(100); let my_map = FxHashMap::default(); // rustc_hash let mut my_map...

@phimuemue I see your performance point about `Vec`. It can always be added later (in the next PR, or any release) as we would not break anything by implementing `Map`...

@SkiFire13 I see you are the author of `GroupingMap`. What do you think of such extension?

@SkiFire13 > The duplication of the methods is a bit unfortunate though. I totally agree, I'm gonna investigate your "add two generics" idea. > Could this be extended to `into_group_map[_by]`...

You might have to roll your own solution (if you did not already did) but as I know the internal well enough after contributing to it, maybe this is simple/general...

First, I agree with **scottmcm**. Skimming the code, I don't think there is a need for a new trait `TryIterator` since a bound like "`E1: Into`" seems enough to me....

I think we might want to deprecate some things once we do #844 (we might want the current discussion there) and there is no rush to deprecate them (0.13.0 already...