Philippe Cholet

Results 17 issues of Philippe Cholet

### What it does Lints implementations of `core::iter::Iterator` that do not specialize the `fold` method. ### Advantage - Methods that consume the entire iterator (`for_each`, `count`, ...) rely on `fold`...

A-lint

Hi, after 80 merged PRs fixing, modifying, testing, benchmarking, specializing or whatever really... I just checked this is my first PR where I actually add a "_brand new_" feature myself....

At the moment, this is only a proof of concept, but it would close #588 (and eventually solve some issues, see https://github.com/rust-itertools/itertools/labels/generic-container). - I wrote a straightforward _private_ trait generalizing...

generic-container

Closes #447. So much changes happened since this work was initiated that rebase on top of master seems nothing less than a nightmare to me (I know, I tried). I...

As of today, `Iterator::map_windows` is nightly: fn map_windows(self, f: F) -> MapWindows where Self: Sized, F: FnMut(&[Self::Item; N]) -> R; But I'm wondering if we should have a version of...

Similar to #601 but for all our iterators and iterator adaptors. Laziness reference: https://doc.rust-lang.org/std/iter/index.html#laziness And I think each iterator struct should have the related `must_use` attribute: - Adaptors: `#[must_use =...

I just created the label "fallible-iterator" and labelled (only opened) related issues and pull requests where the iterator item is fallible: results mostly, options too. It's one recurring topic, and...

fallible-iterator
roadmap

Following the logic of _https://github.com/rust-itertools/itertools/issues/709#issuecomment-1616526337_: > I looked at the methods in `trait Iterator` to find the way the "std" considers "iterator ownership". > There are 4 cases: > >...

breaking-change

Fixes #963 I suggest we follow the same policy as the stdlib: https://std-dev-guide.rust-lang.org/policy/doc-alias.html And I agree with @VorpalBlade that [`comm`](https://www.man7.org/linux/man-pages/man1/comm.1.html) is a fitting alias. PS: Doc aliases requires rust 1.48...

Closes #667 and maybe #307. I merely update the docs of `Itertools::format[_with]`, reformulations are welcome: > ⚠ This can happen discreetly and be hard to debug if used in _macros...