Philipp Imhof

Results 145 comments of Philipp Imhof

Hello Dominque, and thanks for your input! I do absolutely agree with you that reusing names of built-in functions or constants is bad practice. However, I think that my role...

> One example: there was no `intdiv()` function prior to PHP 7. But integer division is a thing, so it is safe to assume that some people had implemented such...

Dear Dominique > You advocate backward compatibility to justify some changes, yet you disregard it for others (INF and more). * The change with INF was a necessary change in...

> > Take the following problem: "Calculate the sine of …." Answer type is "Numerical formula", because you want students to be able to write things like sqrt(3)/2. Now that...

> There are many problems in physics where it is convenient to use the constant **INF**, for example with logical tests such as `if ($x === INF)` or with the...

If we do no longer consider `INF` and `-INF` as problematic return values, then [what you described here](https://github.com/FormulasQuestion/moodle-qtype_formulas/issues/189#issuecomment-3383234607) will not work anymore: > In previous versions of the Formulas question...

This functionality already exists, but it is at the quiz level: ![Image](https://github.com/user-attachments/assets/ba8dedfb-6945-43ac-bcea-98009ccabb79) IMHO it does not make sense to implement it at the question level, as it can lead to...

I see your point. Note, however, that you could easily have the model answer as `3.9` with unit `a`, so that would be shown in the automatic feedback. There would...

> Consistently, if the requested feature of hiding the automatic “The correct answer is: …” message is implemented, I strongly recommend that it be applied at the part level, not...

Thanks for reporting this. That odd behaviour is explained here: https://github.com/FormulasQuestion/moodle-qtype_formulas/pull/164#issuecomment-2698593955 Unfortunately, rewriting the entire unit system takes quite some time...