Philipp Imhof

Results 154 comments of Philipp Imhof

Thanks @tlock for your very detailed report. I am a bit surprised, because I used the "official" unit tests to test my plugin when I implemented the changes that MDL-83541...

I have looked into it again and found the source of the problem. As you correctly pointed out, our own version of the test function differs from the one in...

I have briefly discussed this in the Moodle developer chat. I will open an issue in the tracker and submit a patch to change the core unit test. Therefore, I...

@tlock I have opened [MDL-85350](https://tracker.moodle.org/browse/MDL-85350). While preparing the change, I discovered that there is a fundamental difference between 4.5 and 5.0 or main. The tests do not fail on 5.0...

You mean, you do that locally? I have a patch ready for core, but I am waiting for feedback from the Moodle developers.

@tlock A quick update: Due to some changes to the question bank from Moodle 5.0 onwards, the test behaves differently for 4.5 and 5.0. This problem is addressed in [MDL-85556](https://tracker.moodle.org/browse/MDL-85556)...

@tlock Just to let you know that the fix for MDL-85556 is currently in integration review. I will keep you posted.

MDL-85556 has been integrated and closed. I have updated [MDL-85350](https://tracker.moodle.org/browse/MDL-85350) with a patch that would fix the issue by skipping over 3rd party plugins that use answers, but do not...

Hello @tlock My patch for [MDL-85350](https://moodle.atlassian.net/browse/MDL-85350) has been integrated and tested, it will be available in Moodle's public repositories very soon, probably by Monday. Best regards

@tlock The fix is now included in the official Moodle repositories and branches. I am therefore closing this; if anything goes wrong, please do not hesitate to open it again.