Philipp Imhof

Results 145 comments of Philipp Imhof

Hello @mijenner As you might have seen in #228, I am currently implementing localised number formatting. However, the locale setting will not be taken into account for **entry** of results....

Hello Jakob and thanks for the contribution. There is one problem though: the 5.3 branch is no longer under active development. And for the 6.x branch (main), I have already...

As a side note, it is still planned to integrate handling of comma as a decimal separator in future versions (maybe 6.1.x). But unfortunately, it's more complicated than just to...

Good to know that you mainly did it, because you needed it, so I do not make you lose your time. I want to make it very clear that I...

I will now lose this PR, as localised number formatting will be implemented in PR #228 I invite you to have a look over there and submit your feedback or...

Some examples to illustrate the current limitations. Given a question with the answer `3600 s`. | Other rules | Answer | Grading | |---|---|---| |`min = 60 s; h =...

I don't quite understand one thing: On one hand, you explain that this is a bug in Moodle and your explanation sounds convincing. But then you say this: > If...

Short traceback: https://github.com/moodle/moodle/blob/4d4369e073980298991a4c9478dd8e998e5518ec/mod/quiz/attempt.php#L43-L44 ```php // Get submitted parameters. $attemptid = required_param('attempt', PARAM_INT); ``` https://github.com/moodle/moodle/blob/4d4369e073980298991a4c9478dd8e998e5518ec/lib/moodlelib.php#L656-L658 ```php function required_param($parname, $type) { return \core\param::from_type($type)->required_param($parname); } ``` https://github.com/moodle/moodle/blob/4d4369e073980298991a4c9478dd8e998e5518ec/lib/classes/param.php#L451-L453 ```php public function required_param(string $paramname): mixed...

Thanks for these explanations, Daniel. I will raise that in Moodle's developer chat. I still do not understand how WebKit can simply "lose" a request parameter.

Correction: I do now understand why that parameter is (probably) lost. When hitting the "Reload" button, Safari (so probably all WebKit browsers) does not re-initiate the POST request that triggered...