Petr Heinz

Allow usage with Symfony 4

1

It seems that this package is in fact compatible with Symfony 4 already, so it should be enoughto change its requirements in `composer.json`. I've created this little PR to add...

[framework] Service alias misconfiguration detector

3

| Q | A | ------------- | --- |Description, reason for the PR| You can easily forget to declare service aliases on your project. This PR adds an automated detector...

[framework] Add commonly used methods to Price class

2

- `multiply`, `isZero` and `equals` are safe to use in `Price` and are commonly needed - comparing `Price` objects is unsafe as there are two independent comparable parts in each...

Helper classes for testing of SSFW should be extracted into their own package

5

### What is happening In `shopsys/framework` package, there are currently some helper classes for testing (introduced in #821 and #1245). The `Tests/FrameworkBundle/Test` namespace was added to the non-dev autoloader in...

Confusing and error-prone access to sizes in ImageEntityConfig

4

### What is happening The usage of methods `getSizeConfig()`, `getSizeConfigs()`, `getSizeConfigByType()` and `getSizeConfigsByType()` in [`ImageEntityConfig`](https://github.com/shopsys/shopsys/blob/master/packages/framework/src/Component/Image/Config/ImageEntityConfig.php) is confusing and error prone. The methods without `ByType` suffix get only image sizes for...

remove option macro from forms, use separate form types instead

11

### What is happening At the moment, all form types have a custom option named `macro` (see FormRenderingConfigurationExtension). This feature is completely undocumented and behaves very unexpectedly - it is...

Systematic escaping of e-mail variable replacements

6

### What is happening In #1120, we escape specific variable replacements in e-mails. This is working solution, but it's relatively brittle - there is a possibility that developers extend the...

## Describe the bug Working with functional tests is very confusing at the moment: - GraphQL functional tests boot at least 2 or 3 Kernels for every test case -...

Translation msgids extracted in project repository don't inherit the original msgstr

7

### What is happening As a developer of a project base, when I run `php phing dump-translations` the translation messages used in my code some configuration and templates are extracted...

Hello, I've experienced some strange behavior of `Decimal::fromFloat()` when lowering the scale using the second parameter. I've provided additional tests and fixed the behavior using `innerRound` so it's consistent with...