shopsys
Confusing and error-prone access to sizes in ImageEntityConfig
What is happening
The usage of methods getSizeConfig(), getSizeConfigs(), getSizeConfigByType() and getSizeConfigsByType() in ImageEntityConfig is confusing and error prone.
The methods without ByType suffix get only image sizes for the default (null) type with is not obvious in code. To make things worse, getSizeConfigsByType does not work when null is provided even though getSizeConfigByType(null) works as intended.
This leads to issues such as the one fixed in #1094.
Expected result
There is only one of methods ImageEntityConfig::getSizeConfig() and ImageEntityConfig::getSizeConfigByType() which accepts string|null $type parameter.
There is only one of methods ImageEntityConfig::getSizeConfigs() and ImageEntityConfig::getSizeConfigsByType() which accepts string|null $type parameter.
(or one of them is deprecated and the deprecated method is not called from within Shopsys Framework)
This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically closed because there was no acivity within the last half a year.
Image sizes were completely removed from the backend in https://github.com/shopsys/shopsys/pull/2924 so none of the methods is there anymore :slightly_smiling_face:
