shopsys icon indicating copy to clipboard operation
shopsys copied to clipboard

Helper classes for testing of SSFW should be extracted into their own package

Open PetrHeinz opened this issue 6 years ago • 5 comments

What is happening

In shopsys/framework package, there are currently some helper classes for testing (introduced in #821 and #1245). The Tests/FrameworkBundle/Test namespace was added to the non-dev autoloader in #871 because otherwise those classes cannot be used from project repository.

Also, shopsys/framework should in fact have a non-dev dependency on phpunit/phpunit and codeception/codeception and it's autoloaded classes are dependent on these packages. This was avoided so that the testing frameworks are not installed in production.

Expected result

Similarly to shopsys/http-smoke-testing, these helper classes should be extracted into their own package (I would suggest shopsys/framework-testing). This package would depend on shopsys/framework (for common concepts such as Money class) and the test-related packages phpunit/phpunit, codeception/codeception and maybe more; and the packages shopsys/framework and shopsys/project-base would have a dev-dependency on the newly extracted package (so they can use the package during testing).

This will give us the opportunity to move more common classes and concepts that are useful for testing of Shopsys Framework from shopsys/project-baseto this package, keeping the project repository smaller and gaining upgradability of those test helper classes.

PetrHeinz avatar Jul 23 '19 15:07 PetrHeinz

seems like a good idea, there could be even EntityExtensionTest as it doesn't make sense for the project implementation

simara-svatopluk avatar Jul 24 '19 18:07 simara-svatopluk

This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 19 '19 11:12 stale[bot]

This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 17 '20 12:04 stale[bot]

This issue has been automatically closed because there was no acivity within the last half a year.

stale[bot] avatar Jun 17 '20 03:06 stale[bot]

This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 17 '20 20:10 stale[bot]