Dylan Perks

Results 361 comments of Dylan Perks

Merged main because CI decided it didn't want to run otherwise

Note: - the tenet labels don't mean anything for any non-3.0 issues, as they are not defined until 3.0. - all issues should have area labels. we're slippy on this,...

> Also I am not sure if GlfwWindow.UnregisterCallbacks acutally unregisters all of them. At least GCUtility.Unpin does not find the corresponding handles. To me it looks like only the most...

Will mark this as a community bugfix, as this the smallest memory leak ever, not variable, that in practice is benign. We'll be happy to accept PRs for fixing this!...

We could probably use the native API entry point’s hash code as the slot, not sure how you get that from an IMarshalContext but Kai should know

> The constructor of MarshalContext already has IMethodSymbol as an argument. I'd say we'd probably want `entryPoint` as an argument & property as well ([this ProcessMethod parameter](https://github.com/dotnet/Silk.NET/blob/main/src/Core/Silk.NET.SilkTouch/NativeApiGenerator.cs#L386)) so that the...

To clarify: I'd prefer the slot to be per native entrypoint rather than per entire method, because what if we had two overloads of the same native function but with...

The GC utility code has been with us for 3 years now!

We could just have a catch-all Key event. ```cs event Action Key; ``` This would be non-breaking and could be accepted into 2.X.

We can't do breaking changes for 2.X so it'll have to be 3.0. Silk.NET 3.0 has an official release date of December 31st 9999 but realistically won't be any time...