Paul Berg

There's no point in having them as "public" because they are called by no other function in the contract. Marking them as "external" would save a bit of gas.

In https://github.com/hifi-finance/hifi/commit/087d03b412ad3e1109d0d4f56dec631ffc15af93, we eliminated the `tasks` package, and moved the tasks in one of the smart contracts package (the one associated with each contract deployed). One of the side-effects of...

[amm] Prove construction safety for "hTokenOutForUnderlyingIn" and "underlyingOutForHTokenIn"

2

## Problem Statement In the [hTokenOutForUnderlyingIn](https://github.com/hifi-finance/hifi/blob/6fbaf2b2d0af49b071a29d3157ed5e10da460b1c/packages/amm/contracts/math/YieldSpace.sol#L143) and the [underlyingOutForHTokenIn](https://github.com/hifi-finance/hifi/blob/6fbaf2b2d0af49b071a29d3157ed5e10da460b1c/packages/amm/contracts/math/YieldSpace.sol#L253) functions, the last operation is a subtraction: ```solidity hTokenOut = hTokenReserves - newHTokenReserves; ``` And: ```solidity normalizedUnderlyingOut = normalizedUnderlyingReserves - newNormalizedUnderlyingReserves;...

The current approach is to expect the end user to *know* the path of the Hifi-related contract they want to interact with. Refer to the [code snippets](https://github.com/hifi-finance/hifi/tree/3308a45a03838da9a31458ceed0aeef3a7152615/packages/amm#javascript) in the README...

All arguments come normalized in the functions defined in `YieldSpace.sol`, except for the `timeToMaturity` argument, which is normalized internally in the library. The style would be more consistent if we...

[protocol] Let the "debtCeiling" be initialized in "listBond"

2

It would reduce the number of contract calls the protocol admin has to undertake when initializing the protocol. Ditto for "collateralizationRatio" and "liquidationIncentive " in "listCollateral".

CI: don't delete coverage reports for non-modified packages

3

When only 1/3 or 2/3 of packages have been modified, the Coveralls GitHub action deletes the previous coverage report for the non-modified packages.

Unfortunately, the script I wrote last month is still failing in [certain](https://github.com/hifi-finance/hifi/issues/22#issuecomment-920760316) circumstances. I will switch back to running integration on all packages, regardless of what has been modified. I...

[amm] Test "getMintInputs" and "getBurnOutputs"

1

These functions are tested as part of the integration tests for the trade functions, but we should go the extra mile and write unit tests for them.

Fix concurrent cache writing issue in CI

1

The `@actions/setup-node@v2` action is used in four jobs in the CI workflow, which causes the following error: > Unable to reserve cache with key node-cache-Linux-yarn-ed73988f6a7bd1a0270433a2d2ff89c15016643cf8f05a2fb87a270786528399, another job may be creating...