Paul Berg comments

Results 723 comments of


                                            Paul Berg

[protocol] Let the "debtCeiling" be initialized in "listBond"

Well, implementing this would help with lowering the overall gas prices of bootstrapping the protocol. At current ETH prices, that'd be helpful.

[amm] Test the arguments emitted in the "Trade" event

See https://github.com/EthWorks/Waffle/issues/437.

Add a husky rule to check that the scope is one of the workspace packages

We could use [config-lerna-scopes](https://github.com/conventional-changelog/commitlint/tree/3fced838935de6c90a278674fe4ae975940262d2/%40commitlint/config-lerna-scopes) for this. It's compatible with yarn workspaces.

Unclear how to set style when using the CLI

Oh, I didn't know about the config file. Thanks for the tip @danielpza!

Allow reverting with signature `error Panic(uint)`

Yes, this would be helpful. [This](https://github.com/hifi-finance/prb-math/blob/v2.2.0/contracts/PRBMathUD60x18Typed.sol#L39-L41) is the specific place where I am reverting with a custom error that mimics `Panic`: ```sol if (rValue < x.value) { revert PRBMathUD60x18__AddOverflow(x.value, y.value);...

Table tests

+1 for this feature. I'm porting my math library to Foundry and there are lots and lots of situations where table tests would be useful. Possibly dumb question, but couldn't...

Table tests

In the meantime, if you're using @emilianobonassi's solution (which is great!) and compiling with Solidity v0.8, consider wrapping the increment in an `unchecked` block: ```solidity modifier parametrizedTest() { for (uint256...

Table tests

@ChainsightLabs it doesn't, but it's fast enough for my needs.

Fork network name

This is not strictly related to the use case mentioned by @wighawag, but: > Make the HardhatArguments, including the network name, and the taskName available in the config. This will...

"function call to a non-contract account" heuristic doesn't work for view functions that return something

It looks like Hardhat is now returning a [RETURNDATA_SIZE_ERROR](https://github.com/NomicFoundation/hardhat/blob/4e35c9295badc835c574bb49a8a268569ea7123a/packages/hardhat-core/src/internal/hardhat-network/stack-traces/solidity-errors.ts#L248) error instead of [NONCONTRACT_ACCOUNT_CALLED_ERROR](https://github.com/NomicFoundation/hardhat/blob/4e35c9295badc835c574bb49a8a268569ea7123a/packages/hardhat-core/src/internal/hardhat-network/stack-traces/solidity-errors.ts#L251-L252). The latter is what I'd expected Hardhat to return because the test is set up to perform...