Paul Berg comments

Results 723 comments of


                                            Paul Berg

CI: don't delete coverage reports for non-modified packages

Fixed via https://github.com/hifi-finance/hifi/commit/2a8a6bdc41c081023a978518bc01bf6843d1dbd2.

CI: don't delete coverage reports for non-modified packages

This started happening again ... E.g. https://github.com/hifi-finance/hifi/actions/runs/1238767426 uploaded coverage only for the `flash-swap` package.

CI: don't delete coverage reports for non-modified packages

Until #47 gets fixed, this issue is stale.

Fix concurrent cache writing issue in CI

Don't think I can solve this without this missing setting in the `@actions/setup-node` action: https://github.com/actions/setup-node/issues/319.

[amm] Test "getMintInputs" and "getBurnOutputs"

I'm not sure it is worth it to do this .. We already have 100% coverage.

[amm] Prove construction safety for "hTokenOutForUnderlyingIn" and "underlyingOutForHTokenIn"

Note that since this hasn't been proved mathematically yet, I added a require statement right before the last operation of both "hTokenOutForUnderlyingIn" and "underlyingOutForHTokenIn". But I didn't write tests that...

[amm] Prove construction safety for "hTokenOutForUnderlyingIn" and "underlyingOutForHTokenIn"

Benson worked on this and came up with a beautiful explanation for why this construction is safe in the realm of pure mathematics. Now the question is to prove whether...

Include the Hardhat artifacts and the TypeChain bindings in the npm package

Added script that does this in [848393a](https://github.com/paulrberg/contracts/commit/848393a026f87739b4cfb3b18891dff9180ff017).

Include the Hardhat artifacts and the TypeChain bindings in the npm package

Re-opening this as it's not as easy as I thought. The issue is that the name of the package is `@paulrberg/contacts`. I consider the `contracts` directory the root of the...

Implement a "pow" function with a normalization factor to stave off overflow when time to maturity is large

The catch is that PRBMath, unlike YieldMath, used 256 bits to represent the operands. I'm not sure if this is a show-stopper, in the sense that we can't implement a...