Patrick Heyer

Results 313 comments of Patrick Heyer

Finally was able to test this (took a bit of futzing around with the config for it to actually show anything) and got a crash when closing the browser window....

Updated the PR to patch stylesheet files after building the binary and the files have been copied into the app bundle.

I guess this PR is in a good state now. @Developer-Ecosystem-Engineering just two outstanding issues: 1. (Required) Please rebase to take the L10N changes to the locale file into account...

> Hi, I know this isn't seeking testers but I was just testing this pull and had some feedback: > > Remuxed mp4s made with Apple VT HEVC Hardware Encoder...

Apart from open inline comments I'm fine with this.

> local declaration of 'icon' hides instance variable Yeah needs to be fixed in code, ObjC convention is to prefix private variables with an underscore: ``` @private QIcon _icon; }...

I'd guess that's because the only part of our codebase that calls these functions with NULL values is the init code for audio sources (so it doesn't affect these plugins)....

The main problem is that you pass an absolute path as `CMAKE_INSTALL_DATAROOTDIR`, but the default value of this variable is "share" as the actual path is usually composed with the...

While CMake supports it in general, our build system does not because we use `install` for other purposes than just installing the project on the system and we rely on...

Sounds to me like the "active" scene is changed in UI, but not necessarily inside the compositor, because the observed behaviour matches what would happen if the reference to the...