Patrick Heyer

Results 313 comments of Patrick Heyer

> You also need to use the return value of `snprintf()` on Linux because otherwise it could emit `format-truncation` warnings with GCC. > > * [Fix some compillation warnings that...

Fixed the most obvious mistakes - when the char array is created on the stack, `sizeof` is used, otherwise the functions have been amended to pass the size of the...

Added new commits fixing existing implementations that used literals as buffer length.

If possible, please clone and run the program from this repository and attach the output as a text file: https://github.com/SharkyRawr/videotoolbox-list Usually Video Toolbox tries to select the best possible encoder...

Thanks, the relevant parts of that log are: ``` Name: Apple H.263 (SW) Display Name: H.263 Id: com.apple.videotoolbox.videoencoder.h263 ========================= Name: Apple H.264 (HW) Display Name: Apple H.264 (HW) Id: com.apple.videotoolbox.videoencoder.h264.gva.100000983...

Thank you - that's unfortunate as there is not really much we can do out of the box. We'd have to think about how to solve this, e.g. detecting an...

Thank you nonetheless, we will report this to Apple directly.

That's a whole lot of code just to show a "What's new" page - what's the reason for the dependency on mbedTLS and shipping a public key in code(!) for...

FWIW we already ship OBSPublicDSAKey.pem on macOS for Sparkle (_if_ it's enabled in CMake), so we could also ship another PEM as well (if it's not the same key).

> Updated now to use `SecItemImport` for Mac, as well as some switches to Qt utilities to replace some old functions. I checked "OBSPublicDSAKey.pem" that we ship in the Resources...