Patrick Heyer

Results 474 comments of Patrick Heyer

IMO whether a source appears in the mixer should depend on the source capabilities, not on the internal situation of the source. The media source is by default audio-capable, so...

> While I agree with Pat's opinion, the `obs_source_set_audio_active()` method is already in use by other (mainly capture) sources to enable/disable audio when audio is available. As such, this isn't...

@RytoEX I hesitant to merge this PR for the following reasons: 1. rnnoise does not expose its own "strength" parameter (in contrast to SpeexDSP), so there is no actual "denoiser...

> Related to #599 ? Maybe, that one was reported after I posted this issue and I can't remember which original issue led me to investigate this issue, it's been...

Please be aware that we cannot provide support for custom FFmpeg output configurations - you are of course free to ask for assistance on our forums or our Discord. What...

Officially supported codecs are available within the "Standard" output screen and vary by platform and available hardware.

Wouldn't it make more sense to put the devision into brackets to yield the ratio of those two big values (which usually should yield "1" for digital displays anyway) and...

Yeah this PR needs to be checked whether it introduces a performance regression on Retina screens, especially with 120Hz ProMotion displays.

Without checking the power impact of the change (suggesting that the CPU clocks are increased) the CPU time spent on the volume meters is not significantly different with this change...

I guess this change relies on the deallocators of the signals being called when the vector is cleared (which it does). In general I'm not in favour of relying on...