Patrick Heyer

Results 474 comments of Patrick Heyer

Gave the buildstream repo a quick glance, seems to be fine, couldn't spot any (ab)use of secrets or GitHub tokens (not that I expected any). Personally I'd probable prefer to...

> > Have these conditions been met? > > It was for having 25.08 on 32, 25.08 wasn't out and this PR got pushed back for the next release. >...

Changes seem fine overall (apart from specific review comments), though I'm somewhat unsure about the added complexity. Also how does this impact our cache usage? The Flatpak cache is the...

> The `deps.ffmpeg/patches/FFmpeg/0002-libaomenc-presets.patch` and `deps.ffmpeg/patches/FFmpeg/0002-libaomenc-presets-Windows.patch` patches were both authored by [@PatTheMav](https://github.com/PatTheMav) in [#77](https://github.com/obsproject/obs-deps/pull/77) as far as I can tell. Those are also Lain's work.