Paliak
Paliak
This pr is ready to go into beta at [5a16766](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4599/commits/5a16766031995348e9a86520e892917c943445f7) but it has been asked of me to refactor trigger code into a seperate `CalcTriggers.lua` file. TODO: - [x] Move...
I've moved trigger related code to a new file `CalcTriggers.lua`. Some things are likely still broken but i've tested everything that makes sense to implement from https://www.poewiki.net/wiki/Trigger and everything should...
It should be correctly handled in #4599   
Closing as trigger rework has been merged into master.
>we need to create the /workdir directory Did you just use `docker compose up` to run the tests? It should create workdir and cache directories on mount: https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/61b3d1057265a4e1d99e3b3f310a1ca18eb8510b/docker-compose.yml#L31-L33 That umask...
The screenshot above used 
>Should magiclines be magicLines? That's what the person from Stack overflow called it so i kept it like that. Though 'splitLines' would probably be a better name. I'm wondering if...
~~Artefact generation is broken. For some reason new lines are mangled in the GitHub action and docker logs are missing. Marking as draft as this will likely take a while...
The values of the output are now sorted in the xml before being passed into xmllint to prevent them from jumping around. I've thought about writing a custom diff tool...
Seems like the newer version of luajit is a good bit slower.