Paliak

While writing the rundown i did some more testing and i think i've failed to address an issue that exists in current release version of pob. Modifiers to effective source...

The new `calcMultiSpellRotationImpact` still seems to produce wrong values. ~~It's likely still caused by lua being 1 indexed because the order in which gems appear in a group changes the...

Fixed the indexing issues. The lua implementation should now behave like the python one. The 20% error is still concerning though. Would be great if you could take a look...

@QuickStick123 The issue seems to be with all two part skills (Arcanist brand has support part and active part). Putting Arcanist Brand into one group and any other active spell...

I think this pr already does this but i'll have to double check.

The simulation may not be correctly handling cool downs for multiple instances of the same skill in the trigger group. Need to do some more digging into that.

Should be easy to do as i'm already handling that for some skills.

Few things to note. Cool downs across groups are not supported for the same reason CWDT loops are not supported (too many assumptions). Some triggers require all skills to be...

@QuickStick123 I've kept it as a draft as i keep adding things but most of recent changes could've been separate prs if this were merged to beta. The only thing...

@Nostrademous I re-implemented it here. https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4599/commits/c6a2f122dc479d51c07d490471654b5979fa8538 This pr replaces all current trigger logic. You can test to make sure it behaves how you'd expect it to.