PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Published 20 hours ago • verified publisher icon PathOfBuildingCommunity

Unseen Strike trigger support

Open zmike opened this issue 3 years ago • 1 comments

Check version

  • [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • [X] I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

Hidden Blade triggers Unseen Strike every 0.5s while phasing, but this trigger/cooldown rate is not correctly calculated.

What is the actual behaviour/value?

The trigger rate should correlate to the 0.5s cooldown if phasing is enabled, but instead it starts at 1.0 and doesn't scale with cooldown recovery.

How to reproduce the issue

  • Add Hidden Blade to build
  • Enable phasing
  • Attack rate is not correctly updated

Build code

https://pastebin.com/JQ5KtHMK

Screenshots

No response

zmike avatar Oct 21 '21 01:10 zmike

Gem DPS sorting also seems to be broken with this skill.

zmike avatar Oct 21 '21 02:10 zmike

Might be fixed by https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4599 @Paliak ?

QuickStick123 avatar Feb 13 '23 01:02 QuickStick123

It should be correctly handled in #4599 obraz

obraz

obraz

Paliak avatar Feb 21 '23 12:02 Paliak

Great, thanks!

zmike avatar Feb 21 '23 14:02 zmike

It hasn't been merged so will keep this open until.

QuickStick123 avatar Feb 21 '23 22:02 QuickStick123

Closing as trigger rework has been merged into master.

Paliak avatar Oct 02 '23 00:10 Paliak