PX4-SITL_gazebo-classic icon indicating copy to clipboard operation
PX4-SITL_gazebo-classic copied to clipboard

Published 20 hours ago • verified publisher icon PX4

Check magnetic table readout

Open CarlOlsson opened this issue 5 years ago • 6 comments

There was a bug in ECL regarding the readout of the magnetic tables sometimes resulting in a large error in magnetic declination and inclination. We need to check that the same error is not present in SITL

CarlOlsson avatar May 24 '19 07:05 CarlOlsson

@CarlOlsson Any updates regarding this issue?

Jaeyoung-Lim avatar Apr 21 '20 11:04 Jaeyoung-Lim

No, I think we should use the same library for calculating the magnetic field in ECL and SITL. I.e. moving the ecl geo functionality to its own submodule and also include that in SITL would probably be the best

CarlOlsson avatar Apr 21 '20 11:04 CarlOlsson

It's perhaps a bit convoluted, but you could include ecl in sitl_gazebo and use only the ecl_geo library.

dagar avatar Apr 21 '20 13:04 dagar

either that or include ecl_geo in ecl and sitl_gazebo, which one do you prefer?

CarlOlsson avatar Apr 21 '20 13:04 CarlOlsson

I do prefer the approach of bringing ecl_geo to its own submodule and probably rename it, so it becomes agnostic for both sitl_gazebo and ecl.

TSC21 avatar Apr 21 '20 13:04 TSC21

@Jaeyoung-Lim Could you have a look?

LorenzMeier avatar Jan 02 '21 11:01 LorenzMeier