Vincent Petry

Results 325 comments of Vincent Petry

I was about to report the sidebar not closing automatically, it's also an issue on narrow screens, not only mobile. For example on the company instance if you narrow the...

@jimlinntu there's some logic missing that would need to find out how far to scroll up to load previous pages before focussing. So if you search for a term that...

Now thinking, the current logic uses the "last unread message" as the separator between "fetch one page of old messages" and "fetch all new messages". Maybe when the hash in...

With the current logic, if we don't fetch all messages to the bottom, it will conflict with the logic that "long polls for new messages". Should new messages appear in...

@jimlinntu you can start reading here: https://github.com/nextcloud/spreed/blob/master/src/components/MessagesList/MessagesList.vue#L450 this is what happens when the message list needs an update due to switching conversations it will first fetch the old messages `getOldMessages`...

@danxuliu was https://github.com/nextcloud/spreed/pull/4686 your PR where we move away from data channels ?

related https://github.com/nextcloud/nextcloud-vue/issues/2762

ref verification symbol if we choose to add it to the upcoming generic input component: https://github.com/nextcloud/nextcloud-vue/issues/2866

For the message list we should probably use the arrow keys for navigating and tab/shift+tab to move to another field. We shouldn't use tab for switching between messages as it...

In general I think we might want to introduce yet another highlight to be able to select a message. The selection would be done either by clicking or moving with...