Vincent Petry

Results 325 comments of Vincent Petry

yes, reproducible on c.nc.com (NC 24.0.4rc1) this time it's on this menu, if you open and close multiple times, you can see the arrow flying to the right once Talk...

I tried again, I needed to click 10-15 times with different speeds to make it appear. Now, am not sure if it's worth fixing... The only thing that matters I...

wow, the dialog element looks pretty recent, I never heard of it before. the focus trap seemed fine though and I don't think we should switch tech at this point....

I discovered that the case I tried to reproduce was different: it was a legacy non-vue dialog appearing on top of a vue dialog. In such case the focus trap...

according to https://stackoverflow.com/a/64598898 just setting the attribute to null should make Vue remove it

would be good to do some tests with an app that has the sidebar sadly the style guide cannot test the app navigation

does anyone has a working npm link setup to quickly test this ?

> We should consider another approach too imho we could look into polyfills for inert I don't think we should invest time trying to hack this around on our own,...

tabindex="-1" on the container doesn't fix sub-items as far as I remember. we'd need to set this on every link and field within the sidebar and remember its original value,...

idea: would it be possible to unmount the navigation when it's closed after a small delay ? then mount it again when opened ? might cause delays though when mounting...