Vincent Petry

Results 325 comments of Vincent Petry

The latter could be achieved by adding a "token" argument to the new "not found" event in https://github.com/nextcloud/spreed/pull/5082 (pending review/merge). Then the event handler can compare the given token to...

Seems that this PR will bring in additional attributes, we might be able to use them: https://github.com/nextcloud/spreed/pull/5084/files#diff-fd8947d9afe55478ba8e2e1aaec637de34304bc109cd317b5adcece86cbd815eR33

The issue I found is when switching conversations too quickly. Basically, when conversation A was not fully loaded, already switch to conversation B. @mkools if you have it 100% of...

If you get a 404 when switching quickly, I already have ways to reproduce it by having a script switch very quickly between rooms repeatedly: https://github.com/nextcloud/spreed/issues/4670#issuecomment-780694721 Try switching more slowly...

I've just tried locally with approach 4 https://github.com/nextcloud/spreed/issues/4670#issuecomment-781475812 and it doesn't fully work in my simulation. It is still possible to trigger a 404 by switching from A to B...

I've pushed my attempt to https://github.com/nextcloud/spreed/pull/5322 but will require more work or a different approach to also catch the A->B->A switching cases.

see previous attempt https://github.com/nextcloud/spreed/pull/4666

does the escape key also close Collabora ? for a viewer I think escape key closing is fine but not something you can work actively in

@JuliaKirschenheuter steps to reproduce: 1. Open Photos app (also on c.nc.com) 2. Click on the "Videos" section on the left Expected result: document title also says "Videos - Nextcloud" or...

now I'm not sure where I got the list of requirements in the original post, especially the idea that it needs to be possible to tab into them. need to...