Pieter-Jan Briers

Results 273 comments of Pieter-Jan Briers

We reviewed this doc in the maintainer meeting, here are the notes: https://docs.spacestation14.com/en/maintainer-meetings/maintainer-meeting-2024-04-06.html

The problem is that total download size isn't actually known due to compression. The CDN would have to buffer a 150+MB download response to get the total byte size.

> Press ctrl-c to kill it That's a SIGINT, not a SIGTERM. I am not able to reproduce this behavior. Both SIGTERM and SIGINT correctly cause the game server to...

Game bug in part but engine should be made to catch those exceptions more gracefully coming from the simulation.

Ok I checked the relevant piece of code and this specific error doesn't appear to be caught under exception tolerance. It's only an assert but it does seem to indicate...

> I agree, this comment in the code is somewhat bizarre. I'm not really sure what the purpose of the type even is. How are you using it? The implementation...

Oh and this one too I've been trying to chase: ``` [INFO] net: "::": "Socket bound to [::]:59031: True" [INFO] net: "::": "Network thread started" [DEBG] net: "[::1]:1212": Status changed...

> Happy.... eyeballs? https://en.wikipedia.org/wiki/Happy_Eyeballs

Yes, having some sort of way to pass the proxy config to the client engine is gonna be a must.

> Does the client engine even have proxy support? Might need to make a separate PR to robust toolbox or something. Yeah, you're gonna need to add that.